As soon as we have a thumbnail we should stop shimmer#7111
Merged
AndyScherzinger merged 2 commits intomasterfrom Oct 20, 2020
Merged
As soon as we have a thumbnail we should stop shimmer#7111AndyScherzinger merged 2 commits intomasterfrom
AndyScherzinger merged 2 commits intomasterfrom
Conversation
AndyScherzinger
approved these changes
Oct 19, 2020
|
This fixed the issue for me as well |
This happens when a thumbnail is available, but one scrolls and then come back to the thumbnail, as image view is recycled Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
shimmerBigFolder
branch
from
fa5284b to
6ff4de1
Compare
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16218.apk |
Collaborator
|
master-light-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16218-Screenshot-master-light-blue |
Collaborator
CodacyLint
SpotBugs (new)
SpotBugs (master)
SpotBugs increased! |
Collaborator
|
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16218-IT-stable |
Collaborator
|
master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16218-IT-master |
thelittlefireman
pushed a commit
to thelittlefireman/android
that referenced
this pull request
Mar 19, 2021
As soon as we have a thumbnail we should stop shimmer Signed-off-by: thelittlefireman <thelittlefireman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6196
This happens when a thumbnail is available, but one scrolls and then come back to the thumbnail, as image view is recycled
Signed-off-by: tobiasKaminsky tobias@kaminsky.me
Testing
Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.
unit tests
instrumented tests
UI tests